Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contract customization article #31479

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Add contract customization article #31479

merged 10 commits into from
Sep 29, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 29, 2022 •
edited
Loading

Contributes to #30484.

  • Add new article on contract customization - preview.
  • Refresh the "migrate from Newtonsoft" and "custom converters" articles to note that polymorphic deserialization and serializing private fields are now possible.

@gewarren gewarren requested a review from a team as a code owner September 29, 2022 01:41
@dotnet-bot dotnet-bot added this to the September 2022 milestone Sep 29, 2022
@eiriktsarpalis eiriktsarpalis mentioned this pull request Sep 29, 2022
Open
IEvangelist
IEvangelist approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise this looks great!

docs/standard/serialization/system-text-json/custom-contracts.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/custom-contracts.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/custom-contracts.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/custom-contracts.md Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/IgnoreType.cs Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/PrivateFields.cs Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/PrivateFields.cs Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/SerializationCount.cs Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/SerializationCount.cs Outdated Show resolved Hide resolved
docs/standard/serialization/system-text-json/snippets/custom-contracts/SerializationCount.cs Outdated Show resolved Hide resolved
@gewarren gewarren enabled auto-merge (squash) September 29, 2022 22:59
@gewarren gewarren merged commit da16d9b into dotnet:main Sep 29, 2022
@gewarren gewarren added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@IEvangelist IEvangelist IEvangelist approved these changes

@krwq krwq Awaiting requested review from krwq

Assignees
No one assigned
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.
4 participants
@gewarren @eiriktsarpalis @IEvangelist @dotnet-bot